Skip to content

Fix remaining DExpr ownership regressions#21

Draft
stevenvar wants to merge 5 commits into
for-serving-2.20from
steven.dexpr_regression_audit
Draft

Fix remaining DExpr ownership regressions#21
stevenvar wants to merge 5 commits into
for-serving-2.20from
steven.dexpr_regression_audit

Conversation

@stevenvar
Copy link
Copy Markdown
Owner

Summary

Fix a few remaining regressions introduced by the DExpr ownership cleanup in that were not covered by the later follow-up fixes.

What this does

  • preserve missing expression slots instead of rewriting them into constants
  • restore the older selective reshape expression refresh behavior in Grappler shape refinement
  • restore gating for TF<->XLA shape expression propagation
  • distinguish missing expression slots from real unknown expressions using a dedicated missing-expression sentinel

Notes

This PR is intentionally narrow: it keeps the ownership model, and only reverts the behavioral drift that looked unrelated to the ownership migration itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant