ci: split Build into required lint + advisory compile#17
Merged
Conversation
Lint catches build.gradle / plugin / dep regressions without needing the MineColonies jars (which can't be sourced reproducibly in CI — see audit/squire-mod-v2-ci-architecture-2026-05-09.md). Compile stays as continue-on-error so failures from missing libs/ don't poison Dependabot PRs. Closes the 'Build never green' issue documented after 2026-04-21.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The `Build` workflow has never gone green in CI. Going back to 2026-04-21, every run fails with 88 errors of the form `package com.minecolonies.api.entity.ai.statemachine does not exist`.
Root cause is not a regression — it's a CI architecture mismatch. `build.gradle` declares MineColonies as `compileOnly fileTree(dir: 'libs')` and `scripts/fetch-deps.sh` populates `libs/` from a local Minecraft instance (`$HOME/AppData/.../atm10/mods`). CI has no local Minecraft instance, no jar, no way to compile.
Full analysis + path-forward options at `audit/squire-mod-v2-ci-architecture-2026-05-09.md` in the vault. Picked option A (advisory CI, no third-party supply chain) over option F (CurseMaven proxy) — the latter resolves but adds a community-run external to the build path, not worth the trade for a personal mod.
What this changes
Splits the single `Build` job into two:
`lint` (required signal) — runs `./gradlew help tasks` and `./gradlew dependencies`. Catches:
`compile` (advisory) — `continue-on-error: true`. Runs the full `./gradlew build`. Cannot pass in CI without `libs/`, but stays in place so:
Impact on Dependabot
5 stuck PRs (#12 #13 #14 #15 #16) currently red because the unified Build fails. After this lands, they show:
Steve can merge them based on lint signal + manual local verification, instead of staring at a permanently-red queue.
Local dev unchanged
`fetch-deps.sh` still works, `./gradlew build` still works on Steve's authoring machine. This is purely a CI workflow split.