Deprecate dual implementations, add integration tests#15
Open
Deprecate dual implementations, add integration tests#15
Conversation
…ests The codebase had dual implementations: active NodeExecutor+AgentState architecture and orphaned generic Node<S>/Edge<S> traits that were never wired into the module tree. This adds deprecation warnings, 9 integration tests for complex graph patterns, and documentation (ADR-001, migration guide, changelog) to prepare for removal in v0.3.0. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
8a0cd4b to
6205b8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Node<S>,Edge<S>,Router<S>traits (unused, will be removed in v0.3.0)Context
The codebase had dual implementations creating technical debt:
NodeExecutor+AgentState+GraphRunner(used by all examples and built-in nodes)Node<S>,Edge<S>,Runtime<S>(never wired intolib.rs,runtime.rswon't even compile against currentCompiledGraph)This PR re-adds
nodeandedgemodules with#[deprecated]attributes, marksruntime.rsas dead code, and adds comprehensive test coverage for the active implementation. See ADR-001 for rationale.Related: #2 (Epic 1 confirmed complete)
Test plan
cargo test— 56 tests pass (47 unit + 9 new integration)cargo clippy— warnings only in deprecated code🤖 Generated with Claude Code