Fix tests for Filament v5 panel registration#57
Merged
Conversation
In Filament v5 the current panel is only set by the SetUpPanel middleware during HTTP requests, so filament()->getCurrentPanel() returned null in unit tests and the "registers plugin" test failed with "Call to a member function plugin() on null". Also migrate phpunit.xml.dist to the PHPUnit 11/12 schema and ignore the new .phpunit.cache directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Filament v5 (and Laravel 13) support was already declared in
composer.jsonvia #53 and #54, but the test suite was broken on v5: theregisters plugintest crashed withCall to a member function plugin() on nullbecause in v5 the current panel is only set by theSetUpPanelmiddleware during HTTP requests, sofilament()->getCurrentPanel()returnsnullin unit tests.tests/TestCase.php: callFilament::setCurrentPanel('admin')insetUp()so panel-dependent tests have a current panel.phpunit.xml.dist: migrated to the PHPUnit 11/12 schema (removes deprecation warning, uses<source>instead of<coverage><include>, addscacheDirectory)..gitignore: ignore the new.phpunit.cache/directory.Verified locally against
filament/filament 5.6.6,laravel/framework 13.12.0,orchestra/testbench 11.1.0:vendor/bin/pestpasses 6/6,vendor/bin/pint --testpasses.