Fix rendering of VSCode / TypeScript JSON files in GitHub's web view#43
Open
freshgum-bubbles wants to merge 3 commits intostemmlerjs:masterfrom
Open
Fix rendering of VSCode / TypeScript JSON files in GitHub's web view#43freshgum-bubbles wants to merge 3 commits intostemmlerjs:masterfrom
freshgum-bubbles wants to merge 3 commits intostemmlerjs:masterfrom
Conversation
Tell GitHub to render `tsconfig.json` files in the web view as JSON With Comments. This was something I discovered [while working on a project](https://github.com/freshgum-bubbles/typedi/blob/develop/tsconfig.typedoc.json). Support is also added for separate `tsconfig.*.json` files, which seem to be rather popular for using different values for different scenarios / environments. Happy to remove this if it doesn't align with the project goals.
freshgum-bubbles
added a commit
to freshgum-bubbles/typedi
that referenced
this pull request
Oct 9, 2023
This is in-line with a pull request also made to a TypeScript starter template project, as seen below: <stemmlerjs/simple-typescript-starter#43>
freshgum-bubbles
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tell GitHub to render
tsconfig.jsonfiles in the web view as JSON With Comments.This was something I discovered while working on a project.
Support is also added for separate
tsconfig.*.jsonfiles, which seem to be rather popular for using different values for different scenarios / environments.Happy to remove this if it doesn't align with the project goals.