Add account trustlines metadata endpoint#33
Open
mayasimi wants to merge 1 commit into
Open
Conversation
|
@mayasimi Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Resolve src/routes/account.js and tests/api.test.js before i can merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve #9
summary
Implemented
GET /account/:id/trustlines.This returns all non-native balances for the account and enriches each trustline with issuer-provided asset metadata when available. For each asset, the endpoint loads the issuer account, reads
home_domain, fetcheshttps://<home_domain>/.well-known/stellar.toml, parses[[CURRENCIES]], and returns the matching asset’sname,description, andimage.A couple of implementation details worth calling out:
home_domain, unreachable TOML, parse failures, or missing currency metadata all resolve cleanly totoml: null.Tests added for:
Validation run:
npm.cmd test -- --runInBandpasses: 15/15Note: lint could not be run because the repo is on ESLint 9 but does not currently include an
eslint.config.*file.