Add GHA coordinator for performance evaluation task scatter/gather#791
Draft
cjonas9 wants to merge 6 commits into
Draft
Add GHA coordinator for performance evaluation task scatter/gather#791cjonas9 wants to merge 6 commits into
cjonas9 wants to merge 6 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Creates a GHA coordinator that launches the tasks of the on-release performance evaluation suite and collects their results.
Adds baselines for the apply-load ingest load test (#741).
The architecture of the coordinator, as well as the changes made to the apply-load ingest load test (so that it would fit well with the coordinator), is as follows:
flowchart TB subgraph glue[".github/workflows/ — irreducible glue (YAML)"] coord["release-evaluation.yml<br/>build · areas · apply-load · report"] lt["load-test.yml<br/>dispatch EC2 · upload artifacts"] end subgraph pkg["cmd/stellar-rpc/internal/releaseeval/ — NEW: all logic + config"] eval["eval.go<br/>PerfReport schema · thresholds · compare"] rep["report.go<br/>render · aggregate · runGate"] thr["thresholds.json (//go:embed)"] gate["gate_test.go<br/>TestReleaseGate (env-gated entrypoint)"] unit["eval_test.go (unit tests)"] end subgraph it["cmd/stellar-rpc/internal/integrationtest/"] al["ingest_loadtest_test.go"] end ec2["EC2 box: run-load-test.sh<br/>runs apply-load test → bench-results.json"] coord -- "report job:<br/>go test -run TestReleaseGate" --> gate coord -- "apply-load job" --> lt --> ec2 ec2 -- "bench-results.json + area-*/status.json<br/>(artifacts)" --> gate gate --> rep --> eval thr -. embedded .-> eval unit --> eval al == "imports PerfReport schema ★ #741 edit" ==> eval ec2 -. "builds & runs" .-> al classDef edit741 fill:#ffe0e0,stroke:#cc0000,stroke-width:3px,color:#000; class al edit741;Why
[TODO]
Known limitations
N/A. Remaining work for the epic this task is a part of mainly includes finishing off the other perf eval tasks (only the ingest load test is complete at this point).