Protocol 28 (CAP-0083) support#788
Closed
sisuresh wants to merge 2 commits into
Closed
Conversation
Re-pin go-stellar-sdk to the CAP-0083 XDR regeneration (SPIKE) and enable the cap_0083 feature on stellar-xdr (=27.0.0, already carries the generated types) so the EmptyTxSet StellarValueType variant is compiled in. rs-soroban-env unchanged; no version bump.
This was referenced Jun 15, 2026
The gomoddirectives linter (enabled via `default: all`) rejects the `replace github.com/stellar/go-stellar-sdk => github.com/sisuresh/go` directive added for the CAP-0083 SPIKE, failing the Go workflow and the `complete` gate. Add it to gomoddirectives' replace-allow-list. Revert once go-stellar-sdk#5952 merges and the replace is dropped for a tagged release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
go-stellar-sdkto the CAP-0083 XDR regeneration (replace→ fork SPIKE9856e203).cap_0083on thestellar-xdrdep (keep=27.0.0, which already carries the generated types) so theEmptyTxSetStellarValueTypevariant compiles in.golangci-lint: allow the go-stellar-sdk SPIKEreplaceingomoddirectivesreplace-allow-list(unblocks thecompletegate). Revert when the SDK lands a tagged release and thereplaceis dropped.Deferred
rs-soroban-envunchanged; nostellar-xdrversion bump;Cargo.lockuntouched (feature-only).Upstream (blocking; flip
replaceto the merged commit + mark ready once it lands):Downstream sibling: