Bump current version of soroban-env to latest tip#763
Bump current version of soroban-env to latest tip#763github-actions[bot] wants to merge 1 commit into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 242373a5b7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| git = "https://github.com/stellar/rs-soroban-env" | ||
| rev = "b03d2563f3a08d51095a19bdbb6d90364b8ce04a" |
There was a problem hiding this comment.
In the checked scripts/check-dependencies.bash section, PROTOS is extracted with sed by matching package = "soroban-env-host" and inspecting only the immediately following line for version; with the new git/rev lines inserted before version, the current lane is no longer discovered (the existing command now yields only 26). That makes the dependency/XDR checks silently skip protocol 27, so current-protocol mismatches can pass CI unless the version stays adjacent to package or the script is updated to parse the TOML structure.
Useful? React with 👍 / 👎.
github-actions
Bot
force-pushed
the
automation/bump-soroban-env
branch
from
242373a to
bc66771
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bc66771f5d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| git = "https://github.com/stellar/rs-soroban-env" | ||
| rev = "b03d2563f3a08d51095a19bdbb6d90364b8ce04a" |
There was a problem hiding this comment.
In environments that build with the workspace's declared MSRV (rust-version = "1.79.0"), this new git dependency resolves to rs-soroban-env at b03d2563, whose workspace manifest requires Rust 1.84.0; Cargo will reject the dependency before building, even though this repo still advertises 1.79. This matters for consumers or Docker/CI invocations that pin the documented Rust version rather than using stable, so the workspace rust-version/toolchain should be raised with the dependency bump.
Useful? React with 👍 / 👎.
github-actions
Bot
force-pushed
the
automation/bump-soroban-env
branch
from
bc66771 to
e8a580e
Compare
github-actions
Bot
force-pushed
the
automation/bump-soroban-env
branch
from
e8a580e to
51b7c39
Compare
Automated update for the
soroban-envdependency onprotocol-next.