Protocol 27 (CAP-0071) support#753
Closed
sisuresh wants to merge 4 commits into
Closed
Conversation
sisuresh
commented
May 28, 2026
sisuresh
changed the title
Contributor
Author
|
Update (CAP-71-only for p27 release) P27 ships with CAP-0071 only — CAP-0083 deferred. Pushed the dep bumps:
|
The released SDK v0.4.0 predates CAP-0071: it lacks the new XDR (SorobanCredentialsAddressWithDelegates, SorobanDelegateSignature, etc.) and the ledgerbackend GetLedgerRaw API. Pin the protocol-27 XDR build via the sisuresh/go replace until go-stellar-sdk#5945 is released. Also transitively bumps stellar/go-xdr to 0bf8f49 (stellar#32), raising DecodeDefaultMaxDepth 250 -> 1500 so deep CAP-71 delegate chains decode.
The SDK's ledgerbackend.LedgerBackend interface gained GetLedgerRaw; fixes the golangci-lint typecheck failure.
The Go/Rust XDR revision comparison fetched xdr_commit_generated.txt from stellar/go-stellar-sdk at the required version, ignoring any replace directive. With the SDK replaced by the CAP-71 fork build, the check compared the stale v0.4.0 XDR (cff714a5) instead of the actual one (68fa1ac, matching rust stellar-xdr 27.0.0) and failed spuriously — the same mismatch that was already failing on protocol-next (stellar#761). Resolve the module through the replace so the check validates what is actually built.
gomoddirectives rejects all replace directives by default; allow the CAP-71 Go XDR pin until go-stellar-sdk#5945 is released.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch was used to stand up an end-to-end Stellar Quickstart test of CAP-0083 ("Allow validators to vote to skip the current ledger", stellar-core PR #5209), together with CAP-0071. It carries the downstream changes required so a custom quickstart image (CAP-83
stellar-core+ this component) runs at protocol 27 and handles CAP-83 skip ledgers (STELLAR_VALUE_EMPTY_TX_SET).Rebased on
main; opened againstprotocol-next.stellar-rpc
go-stellar-sdkto the CAP-71/CAP-83 Go XDR build (so RPC ingests CAP-83 skip-ledger meta).-currsoroban-env-host/soroban-simulationat the CAP-71 hostrs-soroban-env@7fb0a840via the pre-release git-ref pattern. Note: the releasedsoroban-env-host 26.1.2predates CAP-71 (#1607), so a git ref is required until a CAP-71 release exists (swap back to a version pin then). Matchingrs-stellar-xdr@a749b69b(cap_0071);xdr2jsonadapted to its single-module layout.