Skip to content

Update stellar-core to v25.1.0rc2#149

Closed
bboston7 wants to merge 1 commit into
stellar:mainfrom
bboston7:update-core-v25.1.0rc2
Closed

Update stellar-core to v25.1.0rc2#149
bboston7 wants to merge 1 commit into
stellar:mainfrom
bboston7:update-core-v25.1.0rc2

Conversation

@bboston7

Copy link
Copy Markdown
Contributor

This updates the horizon workflow to use stellar-core v25.1.0rc2 in CI.

This updates the horizon workflow to use stellar-core v25.1.0rc2 in CI.
Copilot AI review requested due to automatic review settings January 15, 2026 00:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the stellar-core version used in the Horizon CI workflow from v25.0.0 to v25.1.0rc2 for both protocol versions 24 and 25.

Changes:

  • Updated stellar-core version references from 25.0.0-2911.e9748b05a to 25.1.0-2971.rc2.414a5e53d
  • Modified both Debian package versions and Docker image tags for PROTOCOL_24 and PROTOCOL_25

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +35 to +36
PROTOCOL_24_CORE_DEBIAN_PKG_VERSION: 25.1.0-2971.rc2.414a5e53d.noble
PROTOCOL_24_CORE_DOCKER_IMG: stellar/stellar-core:25.1.0-2971.rc2.414a5e53d.jammy

Copilot AI Jan 15, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent Ubuntu distribution versions between Debian package and Docker image. The Debian package uses .noble (Ubuntu 24.04) while the Docker image uses .jammy (Ubuntu 22.04). Since the workflow runs on ubuntu-24.04 (Noble), the Docker image should also use .noble to ensure consistency. This mismatch could cause compatibility issues or unexpected behavior during integration tests.

Copilot uses AI. Check for mistakes.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the core team only pushes up jammy builds for release candidates. I don't see why that would be a problem for running in a container like this, but I've raised this with the team to see if we should be pushing up noble as well.

Comment on lines +38 to +39
PROTOCOL_25_CORE_DEBIAN_PKG_VERSION: 25.1.0-2971.rc2.414a5e53d.noble
PROTOCOL_25_CORE_DOCKER_IMG: stellar/stellar-core:25.1.0-2971.rc2.414a5e53d.jammy

Copilot AI Jan 15, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent Ubuntu distribution versions between Debian package and Docker image. The Debian package uses .noble (Ubuntu 24.04) while the Docker image uses .jammy (Ubuntu 22.04). Since the workflow runs on ubuntu-24.04 (Noble), the Docker image should also use .noble to ensure consistency. This mismatch could cause compatibility issues or unexpected behavior during integration tests.

Copilot uses AI. Check for mistakes.
@bboston7

Copy link
Copy Markdown
Contributor Author

Closing in favor of #150

@bboston7 bboston7 closed this Jan 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants