Update stellar-core to v25.1.0rc2#149
Conversation
This updates the horizon workflow to use stellar-core v25.1.0rc2 in CI.
There was a problem hiding this comment.
Pull request overview
This PR updates the stellar-core version used in the Horizon CI workflow from v25.0.0 to v25.1.0rc2 for both protocol versions 24 and 25.
Changes:
- Updated stellar-core version references from 25.0.0-2911.e9748b05a to 25.1.0-2971.rc2.414a5e53d
- Modified both Debian package versions and Docker image tags for PROTOCOL_24 and PROTOCOL_25
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| PROTOCOL_24_CORE_DEBIAN_PKG_VERSION: 25.1.0-2971.rc2.414a5e53d.noble | ||
| PROTOCOL_24_CORE_DOCKER_IMG: stellar/stellar-core:25.1.0-2971.rc2.414a5e53d.jammy |
There was a problem hiding this comment.
Inconsistent Ubuntu distribution versions between Debian package and Docker image. The Debian package uses .noble (Ubuntu 24.04) while the Docker image uses .jammy (Ubuntu 22.04). Since the workflow runs on ubuntu-24.04 (Noble), the Docker image should also use .noble to ensure consistency. This mismatch could cause compatibility issues or unexpected behavior during integration tests.
There was a problem hiding this comment.
It looks like the core team only pushes up jammy builds for release candidates. I don't see why that would be a problem for running in a container like this, but I've raised this with the team to see if we should be pushing up noble as well.
| PROTOCOL_25_CORE_DEBIAN_PKG_VERSION: 25.1.0-2971.rc2.414a5e53d.noble | ||
| PROTOCOL_25_CORE_DOCKER_IMG: stellar/stellar-core:25.1.0-2971.rc2.414a5e53d.jammy |
There was a problem hiding this comment.
Inconsistent Ubuntu distribution versions between Debian package and Docker image. The Debian package uses .noble (Ubuntu 24.04) while the Docker image uses .jammy (Ubuntu 22.04). Since the workflow runs on ubuntu-24.04 (Noble), the Docker image should also use .noble to ensure consistency. This mismatch could cause compatibility issues or unexpected behavior during integration tests.
|
Closing in favor of #150 |
This updates the horizon workflow to use stellar-core v25.1.0rc2 in CI.