Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add socket tier 1 reachability analysis #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
add socket tier 1 reachability analysis #142
Changes from all commits
b3d82cfFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For scheduled/manual runs this command can mark the job green before Socket has actually generated or evaluated the scan report: the Socket CLI docs/
scan create --helpstate thatsocket scan createreturns after creating the scan, while--reportis what waits for and reads the generated report. As written, server-side vulnerability/policy failures or report-generation failures can happen after this step exits 0, so the workflow status no longer matches the documented GREEN/RED meaning; add--reportif the job is intended to verify the completed scan.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fresh Actions runner has no checked-in
socket.json, and the Socket CLI docs say scans default tosocket-default-repository/socket-default-branchunless--repoand--branchare supplied. In this workflow, scheduled scans forjs-xdrwill therefore be filed under the default placeholder repo/branch (and can collide with other repos using the same org token) instead of updating the intended Socket repository/alerts page; pass the repository and branch/default-branch explicitly.Useful? React with 👍 / 👎.
Uh oh!
There was an error while loading. Please reload this page.