xdr3: clarify intentional design of makeArrayPayload in decode limits test#28
Closed
Copilot wants to merge 3 commits into
Closed
xdr3: clarify intentional design of makeArrayPayload in decode limits test#28Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
… limits Add a MaxOutputBytes field to DecodeOptions that tracks cumulative decoded output size across a single decode operation. Before each allocation (array element, union arm, optional field, opaque data), the size is added to a running total; if it exceeds MaxOutputBytes the decode is aborted with ErrOutputBytesExceeded. Key changes: - Add TrackOutputBytes method and TrackOutputBytesOf[T] generic helper - Cap array pre-allocation at 256 elements, growing via append beyond that - Track allocations in DecodeFixedOpaque, decodeArray, decodeUnion, decodeMap, and allocPtrIfNil - Bump minimum Go version to 1.25 for generics support Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2 tasks
Co-authored-by: tamirms <1445829+tamirms@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on MaxOutputBytes decode option
xdr3: clarify intentional design of makeArrayPayload in decode limits test
Mar 11, 2026
tamirms
force-pushed
the
reduce-allocations
branch
from
112f917 to
c677e1b
Compare
|
Closing — improvements from this PR have been incorporated into #22 where applicable. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A reviewer flagged
makeArrayPayloadas incorrectly encoding element count vs. byte length, suggesting the test didn't exercise its intended paths. The design is intentional: the declared element count in the 4-byte header far exceeds elements that actually fit in the payload, simulating a malicious/malformed input that claims a huge array to provoke unbounded allocation.Changes
xdr3/decode_limits_test.go: Expanded themakeArrayPayloaddoc comment to explicitly document that the header/data mismatch is deliberate — the decoder must rely onMaxOutputBytesto cap memory before encountering EOF while reading element data.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.