Skip to content

deps: bump trezor-connect to v9#391

Merged
quietbits merged 1 commit into
stellar:masterfrom
overcat:trezor-v9
Jan 10, 2023
Merged

deps: bump trezor-connect to v9#391
quietbits merged 1 commit into
stellar:masterfrom
overcat:trezor-v9

Conversation

@overcat

@overcat overcat commented Sep 21, 2022

Copy link
Copy Markdown
Contributor

Trezor v8 related npm packages are now in maintenance mode, future updates will be based on Trezor v9

trezor/trezor-suite#5358

@Hannsek

Hannsek commented Jan 9, 2023

Copy link
Copy Markdown

Closes #393

@overcat

overcat commented Jan 9, 2023

Copy link
Copy Markdown
Contributor Author

Blocked by stellar/js-stellar-wallets#333

Since this project depends on stellar/js-stellar-wallets, but js-stellar-wallets is still using the old version of trezor-connect.

@overcat overcat marked this pull request as draft January 9, 2023 13:01
@quietbits

Copy link
Copy Markdown
Contributor

@overcat, there is a chance that updated Trezor will not work through js-stellar-wallets here if it uses WebUSB. We had to implement Ledger connect locally for the Account Viewer because of WebUSB restrictions. I don't remember the details, but it was something to do with only direct action that could launch something—using a library sort of created a 3rd party in the middle, which wasn't allowed. Maybe Trezor handles it differently, wanted to bring this up just in case.

We could just go ahead and implement Trezor connect locally as well, to remove dependency on js-stellar-wallets.

@overcat overcat marked this pull request as ready for review January 10, 2023 03:27
@overcat

overcat commented Jan 10, 2023

Copy link
Copy Markdown
Contributor Author

Hi @quietbits, it looks like I forgot to remove the reference to trezor-connect, but I have now fixed it. I have also tested it on the latest versions of Chrome and Firefox and it seems to be running smoothly.

https://account-viewer-v2-160ixf0uc-overcat.vercel.app/

@quietbits quietbits left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Thank you very much, @overcat!

@quietbits quietbits merged commit b2682d1 into stellar:master Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants