Add shortcut that can pop out tabs to a new incognito window#23
Draft
stefansundin wants to merge 1 commit intomainfrom
Draft
Add shortcut that can pop out tabs to a new incognito window#23stefansundin wants to merge 1 commit intomainfrom
stefansundin wants to merge 1 commit intomainfrom
Conversation
…tabs are already in an incognito window then they will be popped out to a normal window. This obviously loses the navigation history as that cannot be preserved (essentially the tab URLs are just recreated for the new window).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the tabs are already in an incognito window then they will be popped out to a normal window. This obviously loses the navigation history as that cannot be preserved (essentially the tab URLs are just recreated for the new window).
This fixes #22. As this is probably a rather uncommon use case, I do not think I want to merge this PR and release this feature in the main extension. And it requires reintroducing the
tabspermission, which I just got rid of in v1.6.0, which makes me like it even less.To download and use this, simply follow this link to download a zip file of the branch: http://github.com/stefansundin/duplicate-tab/archive/pop-out-to-new-incognito-window.zip
Extract the files in the zip file. You may want to disable the normal "Duplicate Tab Shortcut" extension first, if you have it installed.
If you are using Chrome, open the Chrome extensions page and enable Developer mode. Then click the Load unpacked button and select the
chromefolder. Verify that the version of the loaded extension is 1.6.1. Go in to the extension details and enable "Allow in Incognito" to enable the ability to use this new shortcut to move incognito tabs into a normal window. Set up the keyboard shortcut as you normally do.If you are using Firefox, open
about:debugging#/runtime/this-firefoxand then click the Load Temporary Add-on... button and select themanifest.jsonfile in thefirefoxfolder. Then openabout:addonsand navigate in to the extension details. Verify that the version of the loaded extension is 1.6.1. Scroll down and enable "Run in Private Windows", otherwise this feature does not work at all in Firefox. Set up the keyboard shortcut as you normally do.Enjoy. Please feel free to discuss this feature here or in the original issue #22.