Fix typo in distributed_utils.py and remove unused variables#900
Open
Chessing234 wants to merge 1 commit intostate-spaces:mainfrom
Open
Fix typo in distributed_utils.py and remove unused variables#900Chessing234 wants to merge 1 commit intostate-spaces:mainfrom
Chessing234 wants to merge 1 commit intostate-spaces:mainfrom
Conversation
Fix typo `pamams_shared` -> `params_shared` in sync_shared_params. The variable name was misspelled but functionally correct since it was only used locally; this fix improves readability. Also remove unused `batch_shape` variable in _get_states_from_cache in both mamba_simple.py and mamba2.py. The variable was assigned but never referenced. Signed-off-by: Taksh <taxkothari@gmail.com> Signed-off-by: Taksh <takshkothari09@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
distributed_utils.py:pamams_shared->params_sharedinsync_shared_params(). The variable name was misspelled but functionally correct since it was only used locally; this fix improves readability.batch_shapevariable: In bothmamba_simple.pyandmamba2.py,_get_states_from_cacheassignedbatch_shape = (batch_size,)but never used it. Removed the dead assignment.Test plan
sync_shared_paramsstill works correctly for distributed training_get_states_from_cachebehaves identically in both Mamba and Mamba2 modules