Use closest origin that has field localized#598
Merged
Conversation
Boefjim
reviewed
Jun 3, 2026
| $directOriginData = $directOrigin->data(); | ||
|
|
||
| // remove any fields in entry data that are marked as localized but value is present, and matches origin | ||
| // remove any fields in entry data that are marked as localized but value is present, and does not match origin |
Contributor
There was a problem hiding this comment.
I think this reverted a fix for this comment on the 5.x branch, that had not been applied on the 4.x branch?
This should only remove fields that are present & match with the origin (or now rather the closest origin that localizes the field), so the original comment here seems to be more accurate 🤔
Contributor
Author
There was a problem hiding this comment.
Thanks, I've updated that directly on 5.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Duplicate of #587 but for 5.x branch