Skip to content

[6.x] Fix configure navs permission not working properly #14775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasonvarga merged 2 commits into from
Jun 3, 2026
+14 −1
Merged

[6.x] Fix configure navs permission not working properly #14775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
105bf79
Fix configure navs permission not working
joshuablum Jun 3, 2026
d9fcf09
Add test
joshuablum Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Policies/NavTreePolicy.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,9 @@ class NavTreePolicy extends NavPolicy

public function before($user)
{
if (User::fromUser($user)->isSuper()) {
$user = User::fromUser($user);

if ($user->isSuper() || $user->hasPermission('configure navs')) {
return true;
}
}
Expand Down
11 changes: 11 additions & 0 deletions tests/Policies/NavTreePolicyTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,17 @@ public function trees_are_viewable_with_view_and_site_permissions()
$this->assertTrue($user->can('view', $nav->makeTree('de')));
}

#[Test]
public function trees_are_viewable_and_editable_with_configure_permission()
{
$user = $this->userWithPermissions(['configure navs']);

$nav = Nav::make('test');

$this->assertTrue($user->can('view', $nav->makeTree('en')));
$this->assertTrue($user->can('edit', $nav->makeTree('en')));
}

#[Test]
public function navs_are_editable_with_edit_permissions()
{
Expand Down
Loading