feat(performers): add column-backed query filters#1076
Open
enymawse wants to merge 8 commits into
Open
Conversation
- add direct queryPerformers support for simple performer columns - add ordered cup_size filtering with explicit rank mapping - split and expand performer integration filter coverage
Contributor
Author
|
Integration test failure doesn't seem related to my changes 🤷♂️ |
- remove measurement, career year, enum, and cup size filter cases from performer integration tests
Contributor
Author
|
removed my integration test coverage and the build passed. turns out something in my IT's were breaking. Will revisit to provide coverage. |
- restore measurement-based performer query filter integration tests
- restore career start and end year performer query filter integration tests
- restore enum-backed performer query filter integration tests
- restore cup size performer query filter integration tests
Contributor
Author
|
ITs passed when pushed individually. Not sure what the issue was. Seems to all check good. |
- extend ordered cup size support for performer query comparisons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add direct queryPerformers support for simple performer columns
add ordered cup_size filtering with explicit rank mapping
performer integration filter coverage for new filters
fix #1003
fix #829