-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/ab#2043 helm chart #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: sprint
Are you sure you want to change the base?
Conversation
| name: "Check if Helm chart is correct" | ||
| needs: build | ||
| runs-on: [self-hosted, linux, X64] | ||
|
|
||
| steps: | ||
| - name: get helm | ||
| uses: azure/setup-helm@v4 | ||
|
|
||
| - name: run helm dependency update | ||
| working-directory: target/helm/dave-backend | ||
| run: helm dep update | ||
|
|
||
| - name: run helm template | ||
| working-directory: target/helm | ||
| run: helm template dave-backend |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 2 days ago
To fix the issue, add an explicit permissions block to the check_helm job to constrain the default GITHUB_TOKEN permissions. Since the check_helm job only installs Helm and runs commands against files produced by earlier steps, it doesn’t need to interact with the GitHub API, so we can set permissions: {} (no permissions) for that job. This leaves the existing compliance and build jobs unchanged.
Concretely, in .github/workflows/pr_build.yaml, locate the check_helm job definition starting at line 63. Insert a permissions: {} block under the existing needs: build (or runs-on) key, with proper indentation to match other jobs. No imports or additional definitions are needed, as this is purely a YAML configuration change for the workflow.
-
Copy modified line R67
| @@ -64,6 +64,7 @@ | ||
| name: "Check if Helm chart is correct" | ||
| needs: build | ||
| runs-on: [self-hosted, linux, X64] | ||
| permissions: {} | ||
|
|
||
| steps: | ||
| - name: get helm |
Description
Adds a Helm chart to deploy Dave Backend.