Skip to content

Conversation

@ztarbug
Copy link

@ztarbug ztarbug commented Jan 14, 2026

Description

Adds a Helm chart to deploy Dave Backend.

  • Acceptance criteria are met
  • Testing is done (unit-tests, DEV-environment)
  • Build/Test workflow has successfully finished
  • Release notes are complemented
  • Documentation is complemented (operator manual, system specification, etc.)

@ztarbug ztarbug requested a review from witchpou January 14, 2026 18:55
Comment on lines +64 to +78
name: "Check if Helm chart is correct"
needs: build
runs-on: [self-hosted, linux, X64]

steps:
- name: get helm
uses: azure/setup-helm@v4

- name: run helm dependency update
working-directory: target/helm/dave-backend
run: helm dep update

- name: run helm template
working-directory: target/helm
run: helm template dave-backend

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}

Copilot Autofix

AI 2 days ago

To fix the issue, add an explicit permissions block to the check_helm job to constrain the default GITHUB_TOKEN permissions. Since the check_helm job only installs Helm and runs commands against files produced by earlier steps, it doesn’t need to interact with the GitHub API, so we can set permissions: {} (no permissions) for that job. This leaves the existing compliance and build jobs unchanged.

Concretely, in .github/workflows/pr_build.yaml, locate the check_helm job definition starting at line 63. Insert a permissions: {} block under the existing needs: build (or runs-on) key, with proper indentation to match other jobs. No imports or additional definitions are needed, as this is purely a YAML configuration change for the workflow.

Suggested changeset 1
.github/workflows/pr_build.yaml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/pr_build.yaml b/.github/workflows/pr_build.yaml
--- a/.github/workflows/pr_build.yaml
+++ b/.github/workflows/pr_build.yaml
@@ -64,6 +64,7 @@
     name: "Check if Helm chart is correct"
     needs: build
     runs-on: [self-hosted, linux, X64]
+    permissions: {}
 
     steps:
       - name: get helm
EOF
@@ -64,6 +64,7 @@
name: "Check if Helm chart is correct"
needs: build
runs-on: [self-hosted, linux, X64]
permissions: {}

steps:
- name: get helm
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants