fix(server-info): trust installed metadata over foreign pyproject + version guard#42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Make distribution identity (dist name + version) a single source of truth in the package root (`my_mcp_server/init.py`) and route the `server-info` MCP resource through it.
Resolution order (now metadata-first)
Why
Previously `server_info.py` re-derived identity on its own, pyproject-first and unguarded: a monorepo-parent `pyproject.toml` encountered on the walk-up would be served as this server's version. It also duplicated the name/version logic, so the two could drift. Now `server_info` consumes `resolve_version()` / `DIST_NAME` from the package root — the reported version can't drift from what the package is, and the foreign-pyproject case is correctly skipped.
`PKG_NAME` is retained in `server_info` as a back-compat alias of `DIST_NAME`.
Tests