fix(audit): detect cd.yml publish workflows by content + correct README check count#49
Merged
Merged
Conversation
…ME check count Two real defects surfaced by the portfolio dogfooding audit (2026-06-04): 1. detectPublishWorkflow filtered candidates by FILENAME (release|publish|deploy), so any repo whose CD workflow is named cd.yml / cd-ios.yml / cd-firefox.yml was missed -> bogus "No publish workflow detected" BLOCKED across 8 starters. Now also matches publish/release actions+commands in the body (npm/pnpm/yarn publish, vsce, ovsx, eas submit, gh-action-pypi-publish, action-gh-release, gh release create, twine, wrangler deploy, docker build-push) and adds `cd` to the filename fast-path. Comment-only mentions are excluded so a changelog-mirror workflow that merely explains the release flow is not misclassified. 2. README claimed audit_security "checks 8 items / 8/8 HARDENED" (lines 18,30) while line 193 and the code list 9 -- self-drift for a tool whose pitch is README<->code parity. Reframed: 8 core CI checks (gate HARDENED) + 1 optional repo-author file (claude-security-guidance.md) = 9. Tests +3 (cd.yml by content, content-only, comment-only non-match); suite 100/100. Verified end-to-end against mcp-server / npm-package. NOTE: the audit's "summary off-by-one" was a stale-branch artifact (chore/code-review-fixes counts core-only; origin/main already counts all) -- no change needed. audit_cd placeholder handling + audit_release origin-anchor / append-only-changelog findings are real and deferred to a follow-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two real defects surfaced by the portfolio dogfooding audit (2026-06-04):
detectPublishWorkflow filtered candidates by FILENAME (release|publish|deploy),
so any repo whose CD workflow is named cd.yml / cd-ios.yml / cd-firefox.yml was
missed -> bogus "No publish workflow detected" BLOCKED across 8 starters. Now
also matches publish/release actions+commands in the body (npm/pnpm/yarn
publish, vsce, ovsx, eas submit, gh-action-pypi-publish, action-gh-release,
gh release create, twine, wrangler deploy, docker build-push) and adds
cdto the filename fast-path. Comment-only mentions are excluded so a
changelog-mirror workflow that merely explains the release flow is not
misclassified.
README claimed audit_security "checks 8 items / 8/8 HARDENED" (lines 18,30)
while line 193 and the code list 9 -- self-drift for a tool whose pitch is
README<->code parity. Reframed: 8 core CI checks (gate HARDENED) + 1 optional
repo-author file (claude-security-guidance.md) = 9.
Tests +3 (cd.yml by content, content-only, comment-only non-match); suite 100/100.
Verified end-to-end against mcp-server / npm-package.
NOTE: the audit's "summary off-by-one" was a stale-branch artifact
(chore/code-review-fixes counts core-only; origin/main already counts all) -- no
change needed. audit_cd placeholder handling + audit_release origin-anchor /
append-only-changelog findings are real and deferred to a follow-up.