typegen: add schema generation#22
Open
zmitry wants to merge 1 commit into
Open
Conversation
starius
approved these changes
Jun 13, 2021
| "ref": "ExampleDirection" | ||
| }, | ||
| "items": { | ||
| "elements": {} |
Owner
There was a problem hiding this comment.
Running go generate ./example results in modification in this file:
@@ -35,7 +35,9 @@ ExampleEchoRequest: {
"ref": "ExampleDirection"
},
"items": {
- "elements": {}
+ "elements": {
+ "ref": "ExampleCustomType2"
+ }
},
"maps": {
"values": {| }, | ||
| }).Parse(GlobalSchemaTemplate) | ||
| panicIf(err) | ||
| tmpl.Execute(writer, map[string]interface{}{ |
Owner
There was a problem hiding this comment.
golangci-lint: Error return value of tmpl.Execute is not checked
| } | ||
| switch { | ||
| case k == reflect.Ptr: | ||
| t = indirect(t) |
Owner
There was a problem hiding this comment.
golangci-lint: this value of t is never used
Comment on lines
+23
to
+25
| _ = os.RemoveAll(filepath.Join(options.OutDir, "schema.ts")) | ||
| schemaFile, _ := os.OpenFile(filepath.Join(options.OutDir, "schema.ts"), os.O_WRONLY|os.O_CREATE, 0755) | ||
| _ = typegen.PrintJDT(parser, schemaFile) |
| } | ||
| return "" | ||
| } | ||
| func SerializeCustomSchema(t reflect.Type) string { |
Owner
There was a problem hiding this comment.
How is this function used? I don't see any usage in api2 itself.
| return nil | ||
| } | ||
|
|
||
| func ToSchema(schema *JSONTypeDefSchema) (*jdt.Schema, error) { |
Owner
There was a problem hiding this comment.
How is this function used? I don't see any usage in api2 itself.
| type JSONTypeDefSchema struct { | ||
| Definitions map[string]JSONTypeDefSchema `json:"definitions,omitempty"` | ||
| Metadata map[string]interface{} `json:"metadata,omitempty"` | ||
| Nullable bool `json:"nullable,omitempty"` |
Owner
There was a problem hiding this comment.
IMHO, bool type should not have omitempty.
| Metadata map[string]interface{} `json:"metadata,omitempty"` | ||
| Nullable bool `json:"nullable,omitempty"` | ||
| Ref *string `json:"ref,omitempty"` | ||
| Type jdt.Type `json:"type,omitempty"` |
Owner
There was a problem hiding this comment.
IMHO, jdt.Type (string) type should not have omitempty.
| Elements *JSONTypeDefSchema `json:"elements,omitempty"` | ||
| Properties map[string]JSONTypeDefSchema `json:"properties,omitempty"` | ||
| OptionalProperties map[string]JSONTypeDefSchema `json:"optionalProperties,omitempty"` | ||
| AdditionalProperties bool `json:"additionalProperties,omitempty"` |
Owner
There was a problem hiding this comment.
IMHO, bool type should not have omitempty.
| OptionalProperties map[string]JSONTypeDefSchema `json:"optionalProperties,omitempty"` | ||
| AdditionalProperties bool `json:"additionalProperties,omitempty"` | ||
| Values *JSONTypeDefSchema `json:"values,omitempty"` | ||
| Discriminator string `json:"discriminator,omitempty"` |
Owner
There was a problem hiding this comment.
IMHO, string type should not have omitempty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.