Add history query#354
Open
cffan wants to merge 3 commits into
Open
Conversation
Pull Request Test Coverage Report for Build 1401
💛 - Coveralls |
gcampax
reviewed
Jun 4, 2021
gcampax
left a comment
gcampax
left a comment
Contributor
There was a problem hiding this comment.
I think this looks ok. You might want to add a compiler and runtime test to be sure.
Another thing I'm wondering about, rather than removing input arguments, we might want to turn them into output arguments, because we'll definitely want to search for history records where we passed certain inputs to a function.
gcampax
approved these changes
Jun 9, 2021
gcampax
left a comment
gcampax
left a comment
Contributor
There was a problem hiding this comment.
Shall we merge this while we work on the Genie side?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.