Skip to content

Conversation

@WardBrian
Copy link
Member

Signatures from stan-dev/math#3258 (comment)

Note that we shouldn't be too worried about the size of the new test files, since the tests in the wiener folder are already excluded-by-default on new PRs.

cc @Franzi2114

Submission Checklist

  • Run unit tests
  • Documentation
    • If a user-facing facing change was made, the documentation PR is here:
    • OR, no user-facing changes were made

Release notes

Added new overloads to the 5/8 argument wiener_lpdf functions with an additional data real argument to control the precision of the gradient.
Added new functions: wiener_lcdf_defective and wiener_lccdf_defective for use with the wiener distribution.

Copyright and Licensing

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)

@WardBrian WardBrian marked this pull request as draft December 12, 2025 15:48
@WardBrian WardBrian marked this pull request as ready for review December 13, 2025 23:29
@WardBrian WardBrian marked this pull request as draft December 17, 2025 14:46
@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.30%. Comparing base (8d78669) to head (962a569).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1576   +/-   ##
=======================================
  Coverage   90.30%   90.30%           
=======================================
  Files          65       65           
  Lines       10050    10050           
=======================================
  Hits         9076     9076           
  Misses        974      974           
Files with missing lines Coverage Δ
src/stanc/CLI.ml 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@WardBrian WardBrian changed the title Add wiener defective cdfs Add wiener unnormalized cdfs Dec 17, 2025
@WardBrian WardBrian marked this pull request as ready for review December 17, 2025 22:07
@WardBrian WardBrian requested review from SteveBronder and removed request for SteveBronder December 17, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants