Replace apply() with storage.mode() for integer to numeric conversion#526
Merged
jgabry merged 2 commits intoApr 6, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes integer-to-numeric conversion inside validate_predictions() by switching from a column-wise apply(..., as.numeric) approach to an in-place storage.mode<- conversion, removing the prior special-case for single-row matrices.
Changes:
- Replace
apply(predictions, 2, as.numeric)withstorage.mode(predictions) <- "numeric"for integer matrices. - Remove the
nrow(predictions) == 1special-case branch sincestorage.mode<-handles all dimensions uniformly.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
apply() with storage.mode() for integer-to-numeric conversion
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #526 +/- ##
==========================================
- Coverage 98.67% 98.67% -0.01%
==========================================
Files 35 35
Lines 5905 5903 -2
==========================================
- Hits 5827 5825 -2
Misses 78 78 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #525
replace
apply(predictions, 2, as.numeric)invalidate_predictions()withstorage.mode(predictions) <- "numeric", an in place conversion that avoids column wise iteration and intermediates. this also removes the unnecessarynrow == 1special case sincestorage.mode<-handles all matrix dimensions uniformly