Skip to content

Restore pre ggplot2 v4.0 behavior of bayesplot theme setting#384

Closed
jgabry wants to merge 1 commit into
masterfrom
fix-theme
Closed

Restore pre ggplot2 v4.0 behavior of bayesplot theme setting#384
jgabry wants to merge 1 commit into
masterfrom
fix-theme

Conversation

@jgabry

@jgabry jgabry commented Oct 24, 2025

Copy link
Copy Markdown
Member

Ensures bayesplot keeps its own default theme by stripping .Environment metadata from ggplot themes before comparison, remembering ggplot’s baseline theme, and only switching to ggplot’s theme when it truly changes.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.92683% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.51%. Comparing base (633addd) to head (4289605).

Files with missing lines Patch % Lines
R/bayesplot-ggplot-themes.R 82.92% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #384      +/-   ##
==========================================
- Coverage   98.62%   98.51%   -0.12%     
==========================================
  Files          35       35              
  Lines        5749     5784      +35     
==========================================
+ Hits         5670     5698      +28     
- Misses         79       86       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jgabry

jgabry commented Oct 24, 2025

Copy link
Copy Markdown
Member Author

I think there are still some kinks to work out

@jgabry jgabry linked an issue Oct 29, 2025 that may be closed by this pull request
@jgabry jgabry closed this Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ggplot2 v4.0 breaks bayesplot theme setting

2 participants