feat(tls): use rustls as default with native-tls as alternative #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implementation changes how TLS is handled. By default, rustls will be used for gRPC communication unless the native-tls feature flag is used at compile time. The main benefit of having rustls is the final binary will be statically linked in full, whereas the native-tls alternative allows to use the system libraries, which is in turn useful to achieve FIPS compliance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This implementation changes how TLS is handled. By default, rustls will be used for gRPC communication unless the native-tls feature flag is used at compile time. The main benefit of having rustls is the final binary will be statically linked in full, whereas the native-tls alternative allows to use the system libraries, which is in turn useful to achieve FIPS compliance.
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed