Skip to content

added test for #6 3d #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cblanquera merged 3 commits into from
Feb 20, 2025
Merged

added test for #6 3d #13

cblanquera merged 3 commits into from
Feb 20, 2025

Conversation

@diujin
Copy link
Contributor

@diujin diujin commented Feb 13, 2025 •
edited by cblanquera
Loading

What is this PR for?

  • Just updating content and/or documentation
  • This fixes issue Allow use "schema.json" #6
  • Spot fix (no issue #)
  • Merging WIP feature #_____
  • Merging done feature #_____
  • This is a merge from a version branch
  • Adding/Updating tests
  • This is a conflict resolution
  • This is a branch cleanup
  • Other: ________________

I verify that...

  • I have logged my time in the commits
  • I have logged my time in this PR
  • I have tagged all the relevant issues
  • I am using VS Code for type checks and linting, or
  • I have ran npm run test with no errors
  • I have manually checked that this bug or feature is working

@diujin diujin changed the title addresses #6 addresses #6 3d Feb 13, 2025
@diujin diujin changed the title addresses #6 3d added test for #6 3d Feb 13, 2025
cblanquera
cblanquera approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member

@cblanquera cblanquera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. thanks

@cblanquera cblanquera merged commit 097b9cc into stackpress:main Feb 20, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cblanquera cblanquera cblanquera approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@diujin @cblanquera