Conversation
Techassi
force-pushed
the
feat/add-eos-checker
branch
from
4d29913 to
eae6280
Compare
Techassi
moved this from Development: In Progress
to Development: Waiting for Review
in Stackable Engineering
sbernauer
requested changes
Oct 6, 2025
Member
sbernauer
left a comment
sbernauer
left a comment
There was a problem hiding this comment.
Rust code change LGTM
We should mention the new EOL checker in the CHANGELOG.md and that it's enabled by default and can be disabled using --eos-disabled.
Technically also a flag to disable CRD maintenance was added, but as this is not used yet, I think I would skip that to not confuse users.
Once we have nice changelog entries we can simply copy/paste them to other operators.
sbernauer
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
sbernauer
moved this from Development: In Review
to Development: Done
in Stackable Engineering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR serves as the model PR to introduce the EoS warning across all other operators.
Part of stackabletech/issues#733. This adds the EoS checker to the operator.