feat: support setting clientAuthenticationMethod for OIDC#716
Open
feat: support setting clientAuthenticationMethod for OIDC#716
Conversation
20 tasks
| client_auth_options: oidc::v1alpha1::ClientAuthenticationOptions { | ||
| client_credentials_secret_ref: "superset-oidc-client2".into(), | ||
| extra_scopes: Vec::new(), | ||
| client_authentication_method: Default::default(), |
Member
There was a problem hiding this comment.
Is the field a String? Just curious what the default value is here.
Member
Author
There was a problem hiding this comment.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of stackabletech/issues#838
The
clientAuthenticationMethodfield from the OIDCClientAuthenticationOptionsis currently deserialized but never used. This PR passes it through to the generatedsuperset_config.pyastoken_endpoint_auth_method.I tested it in a Kind cluster with our Keycloak setup from the OIDC integration test (by setting the client authentication method to
private_key_jwtinstead ofclient_secret_basic, then OIDC login failed, as expected).Requires an operator-rs release with stackabletech/operator-rs#1178.
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker