Conversation
This reverts commit acee691.
NickLarsenNZ
reviewed
Feb 5, 2025
Member
There was a problem hiding this comment.
Is this an accidental left-over?
NickLarsenNZ
reviewed
Feb 5, 2025
Member
NickLarsenNZ
left a comment
There was a problem hiding this comment.
Partial review. Will try to give it a proper look tomorrow.
Member
|
🟢 Tested on Openshift: |
adwk67
reviewed
Feb 6, 2025
adwk67
approved these changes
Feb 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of: stackabletech/issues#666
This PR adds a new binary crate (
olm-deployer) to the secret operator.The binary is bundled in the resulting container image and is only used by the OLM.
How to test
Requirements:
secret-olm-deployerfrom the operators repo.stackable-utilsrepoInstall the secret operator using OLM and the
olm-deployer. From thestackable-utilsrepo, run:The secret op and all it's dependencies should be installed and running in the
stackable-operatorsnamespace.Note
The ClusterSertviceVersion is now using the olm-deployer binary instead of the shell script
This is the relevant part of the
clusterservicedefinition.yamlfile:Integration tests
First checkout
release-24.11branch of the secret operator repo. This is needed becausesecret-olm-deployerbranch deploys the 24.11.0 op version. The fact that 24.11.1 is now latest doesn't matter.