Skip to content

Fix typos#1180

Merged
lfrancke merged 1 commit intomainfrom
push-zozmsuksrsmm
Mar 20, 2026
Merged

Fix typos#1180
lfrancke merged 1 commit intomainfrom
push-zozmsuksrsmm

Conversation

@lfrancke
Copy link
Member

@lfrancke lfrancke commented Mar 18, 2026

Description

Fix typos using typos
I had to fix two things in the README file to make markdownlint happy.
There is actually a typo in a parameter... I hope it doesn't break anything :)

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added

@lfrancke lfrancke moved this to Development: Waiting for Review in Stackable Engineering Mar 18, 2026
@lfrancke lfrancke force-pushed the push-zozmsuksrsmm branch from f87ef7a to 5d5e69b Compare March 19, 2026 11:04
@lfrancke lfrancke force-pushed the push-zozmsuksrsmm branch from 5d5e69b to affb32d Compare March 19, 2026 11:07
@dervoeti dervoeti self-requested a review March 20, 2026 08:46
@dervoeti dervoeti moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Mar 20, 2026
Copy link
Member

@dervoeti dervoeti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope it doesn't break anything

Should not, Rust doesn't have named function parameters and the struct field is private. But I grepped for subject_alterative in the operators, just to be safe, looks good.

@lfrancke lfrancke added this pull request to the merge queue Mar 20, 2026
Merged via the queue into main with commit a000311 Mar 20, 2026
5 checks passed
@lfrancke lfrancke deleted the push-zozmsuksrsmm branch March 20, 2026 18:50
@lfrancke lfrancke moved this from Development: In Review to Development: Done in Stackable Engineering Mar 23, 2026
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants