Allow AD integration to filter LDAP groups#693
Merged
Conversation
Contributor
Author
|
Putting the CRD change decision into RFC. |
sbernauer
previously approved these changes
Feb 25, 2025
Member
sbernauer
left a comment
There was a problem hiding this comment.
CRD and code LGTM. Let's wait for the decision
Member
|
WDYT of calling it |
Contributor
Author
|
Accepted during the meeting, with @sbernauer's suggestion. |
sbernauer
approved these changes
Feb 26, 2025
Member
sbernauer
left a comment
There was a problem hiding this comment.
LGTM. Was waiting for you to resolve the conflicts ^^
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #691
This PR adds a new field
additionalGroupAttributeFilterstoOpaCluster.spec.clusterConfig.userInfo.backend.experimentalActiveDirectory:Any group must match all attributes specified here in order to be included in the UIF report.
Release Note
The OPA user-info-fetcher can now filter Active Directory group membership by LDAP attributes.
Definition of Done Checklist