chore: Describe RBAC rules, remove unnecessary rules#770
Draft
NickLarsenNZ wants to merge 2 commits intomainfrom
Draft
chore: Describe RBAC rules, remove unnecessary rules#770NickLarsenNZ wants to merge 2 commits intomainfrom
NickLarsenNZ wants to merge 2 commits intomainfrom
Conversation
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of stackabletech/issues#798
Note
This was initially generated by a coding assistant to see how well it can inspect code and review the RBAC rules. the changes will be properly checked before reviews are requested.
Explanation
Operator ClusterRole (
{fullname}-clusterrole)nodes(list, watch, get)nodes/proxy. The topology provider runs in product pods viahdfs-clusterrole-nodes, not the operator. Thegetwas added in bc0d9a9 alongside rack awareness but belongs to the product ClusterRole.podssecretsdelete_orphaned_resources()but the operator neveradd()s them, so orphan cleanup finds nothing (framework silently skips on 403).endpoints(both occurrences)updateverb (everywhere)apply_patch).update= HTTP PUT =api.replace(), which is never called anywhere in the operator source.watchon serviceaccounts.own()or.watches()ServiceAccounts.watchon rolebindings.own()RoleBindings.watchon poddisruptionbudgets.own()PodDisruptionBudgets.batch/jobspatchonhdfsclusters/statussubresource viaclient.apply_patch_status(). The main resource is never patched directly.liston listenersadd()s Listeners — they are managed by the listener-operator. Orphan cleanup finds nothing;getalone suffices fornamenode_listener_refs.get,update,list,watchon clusterrolebindingsapi.patch()call. No prior GET is needed; SSA only requirescreate+patch.Product ClusterRole (
hdfs-clusterrole)No rule changes — permissions left as-is per plan guidance for product-level runtime permissions. Added comments explaining the purpose of each resource.
Nodes ClusterRole (
hdfs-clusterrole-nodes)No rule changes. Added comments explaining the topology provider's needs for
pods/nodes/endpointsand the listener lookup flow.