Skip to content

feat(web): drop legacy-blended and shadow transcript tabs#120

Merged
ssarunic merged 1 commit into
mainfrom
feat/drop-legacy-transcript-tabs
May 30, 2026
Merged

feat(web): drop legacy-blended and shadow transcript tabs#120
ssarunic merged 1 commit into
mainfrom
feat/drop-legacy-transcript-tabs

Conversation

@ssarunic

Copy link
Copy Markdown
Owner

What

All episodes now carry segmented transcripts (the last 5 stragglers were backfilled), so the transcript panel's two alternate tabs no longer earn their place:

  • "Legacy blended" — a redundant re-rendering of the cleaned markdown alongside the Segmented view.
  • "Shadow" — a debug tab the backend never actually populates (shadow was never set in the transcript response), so it was dead code.

Changes

  • Remove the sub-tab toggle, the TranscriptSubTab type, SubTabButton, and the ShadowTranscript type / shadow response field.
  • TranscriptViewer stays as the fallback renderer for raw / mid-pipeline / loading episodes — the backend content field still feeds it. Only the user-facing legacy/shadow tabs are removed; the segmented view is now the sole selectable transcript view, with a graceful fallback to the markdown viewer when no segmented sidecar exists.

Verification

  • tsc --noEmit clean
  • Frontend transcript tests green (SegmentedTranscriptViewer + karaoke, 30/30)
  • Full frontend suite green locally (216/216)

Note

Does not touch the backend content/segments API or the summarizer — both still consume the markdown file directly, unchanged. The backfill script lives separately on the entity-enrichment branch's working tree.

All episodes now carry segmented transcripts, so the "Legacy blended"
alternate-rendering tab and the never-populated "Shadow" debug tab no
longer earn their place in the transcript panel.

- Remove the sub-tab toggle, the TranscriptSubTab type, SubTabButton,
  and the ShadowTranscript type / shadow response field.
- TranscriptViewer stays as the fallback renderer for raw / mid-pipeline
  / loading episodes (the backend `content` field still feeds it); only
  the user-facing legacy/shadow *tabs* are removed.

tsc + frontend transcript tests green.
@ssarunic ssarunic merged commit a8a43a9 into main May 30, 2026
5 checks passed
@ssarunic ssarunic deleted the feat/drop-legacy-transcript-tabs branch May 30, 2026 18:21
ssarunic added a commit that referenced this pull request May 30, 2026
Re-runs the spec #18 segmented cleanup (TranscriptCleaningProcessor) on
episodes that have a cleaned Markdown transcript but no AnnotatedTranscript
JSON sidecar, so every episode gets a segmented view. This backfilled the
5 stragglers that predated the segmented pipeline (coverage now 866/866),
which was the prerequisite for dropping the legacy-blended tab in #120.

Idempotent: skips episodes that already have a sidecar unless --force.
Dry-run by default; --apply to write; --episode-id to target specific rows.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant