Closed
Conversation
Change-Id: I30619425e1e1e4ca43286be35a8c4a85658a8acb
include missing NO_VALUE on docstrings Change-Id: I79c4657d5ea8778e2932bae3e81725af27bbef85
Change-Id: I8cd5d4fbf7eabf03e48f5434e6c50dacd07dfd3c
Change-Id: Ib1c0a38f072676f33254a91312e7237c129850f2
* applied typing to other backends * standardized all backends to operate on a copy of the Dict passed in Some backends did this, others did not. Change-Id: I90084c6d0ad23d7bb9988664c2cef1a739fa3ff1
Change-Id: I4b912cfdb7fdae970bd95d418e059bb9965b5832
fixed valkey default for lock_sleep Change-Id: I03c80c105be4ec3b280d57f340b050b16c4d937a
Change-Id: Ib7bf3ebf825c0823e70b29b0ef5ee5f21010616a
Change-Id: I4b00ec1e4faa45b204bc214099d0180c46b08145
Change-Id: Ibac8687f704e06c667ada7eed9386b410ab202f5
This was referenced Aug 24, 2025
Contributor
|
This fixes #273, but it doesn't prove that it does. In order to do so, you'll need to add See #274 for some test setup code you can steal. |
Member
Author
|
@0xDEC0DE Thanks. I think my test did cover this, just differently than you. I've removed the code, and am closing this ticket in favor of my other one, because your PR was merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative to #270
Instead of extending test_region as originally requested, the generic backend fixture modified.
The dict comparison is handled by stdlib's unittest comparison function, which historically works well for complex dicts.