Skip to content

Propagate task definition tags through RegisterTaskDefinition #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
teaguru merged 1 commit into from
May 12, 2026
Merged

Propagate task definition tags through RegisterTaskDefinition #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/deploy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ func deployService(ctx log.Interface, cluster, imageTag string, imageTags []stri
// then describe the task definition to get a copy of it
describeTaskResult, err := svc.DescribeTaskDefinition(&ecs.DescribeTaskDefinitionInput{
TaskDefinition: describeResult.Services[0].TaskDefinition,
Include: aws.StringSlice([]string{"TAGS"}),
})
if err != nil {
ctx.WithError(err).Error("Can't get task definition")
Expand All @@ -107,6 +108,7 @@ func deployService(ctx log.Interface, cluster, imageTag string, imageTags []stri
RequiresCompatibilities: taskDefinition.Compatibilities,
TaskRoleArn: taskDefinition.TaskRoleArn,
Volumes: taskDefinition.Volumes,
Tags: describeTaskResult.Tags,
})
if err != nil {
ctx.WithError(err).Error("Can't register task definition")
Expand Down
2 changes: 2 additions & 0 deletions lib/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ func RunTask(profile, cluster, service, taskDefinitionName, imageTag string, ima

describeResult, err := svc.DescribeTaskDefinition(&ecs.DescribeTaskDefinitionInput{
TaskDefinition: aws.String(taskDefinitionName),
Include: aws.StringSlice([]string{"TAGS"}),
})
if err != nil {
ctx.WithError(err).Error("Can't get task definition")
Expand Down Expand Up @@ -67,6 +68,7 @@ func RunTask(profile, cluster, service, taskDefinitionName, imageTag string, ima
RequiresCompatibilities: taskDefinition.Compatibilities,
TaskRoleArn: taskDefinition.TaskRoleArn,
Volumes: taskDefinition.Volumes,
Tags: describeResult.Tags,
})
if err != nil {
ctx.WithError(err).Error("Can't register task definition")
Expand Down
2 changes: 2 additions & 0 deletions lib/runFargate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ func RunFargate(profile, cluster, service, taskDefinitionName, imageTag string,

describeResult, err := svc.DescribeTaskDefinition(&ecs.DescribeTaskDefinitionInput{
TaskDefinition: aws.String(taskDefinitionName),
Include: aws.StringSlice([]string{"TAGS"}),
})
if err != nil {
ctx.WithError(err).Error("Can't get task definition")
Expand Down Expand Up @@ -111,6 +112,7 @@ func RunFargate(profile, cluster, service, taskDefinitionName, imageTag string,
RequiresCompatibilities: taskDefinition.Compatibilities,
TaskRoleArn: taskDefinition.TaskRoleArn,
Volumes: taskDefinition.Volumes,
Tags: describeResult.Tags,
})
if err != nil {
ctx.WithError(err).Error("Can't register task definition")
Expand Down
Loading