fix startup condition problem with plan#4110
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a ComponentBase startup edge-case where a component can set api_started from a background task before run(first=True) returns, which previously could keep the component stuck in the startup/backoff path and prevent steady-state housekeeping (including plan publishing).
Changes:
- Ensure
ComponentBase.start()clears thefirstflag after any successfulrun(), even ifapi_startedwas already set externally. - Add a regression test covering the “run() pre-sets
api_started” scenario. - Bump Predbat version to
v8.41.3.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/predbat/component_base.py | Clears first after successful startup regardless of who set api_started, preventing repeated startup/backoff runs. |
| apps/predbat/tests/test_component_base.py | Adds a regression test validating first transitions to False even when run() sets api_started before returning. |
| apps/predbat/predbat.py | Version bump to v8.41.3. |
Comment on lines
+336
to
+338
| # Wait long enough (sped up 100x by fast_sleep → ~2s real) for the component | ||
| # loop to advance past simulated seconds=60 so a steady-state run can occur. | ||
| await asyncio.sleep(200) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.