Fix web crash#4100
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a crash in the web UI “apps.yaml” renderer by guarding a substring check against non-string argument keys, and bumps the Predbat version to release the fix.
Changes:
- Prevent
TypeErrorinhtml_apps()by checkingisinstance(arg, str)before using"_key" in arg-style substring tests. - Bump
THIS_VERSIONfromv8.40.15tov8.40.16.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/predbat/web.py | Adds a type guard to avoid crashing when args contains non-string keys while rendering the apps UI. |
| apps/predbat/predbat.py | Increments the application version constant to ship the fix. |
Comment on lines
3380
to
3384
| for arg in args: | ||
| value = args[arg] | ||
| raw_value = self.resolve_value_raw(arg, value) | ||
| if ("_key" in arg) or ("_password" in arg) or ("_secret" in arg) or ("_pem" in arg): | ||
| if isinstance(arg, str) and (("_key" in arg) or ("_password" in arg) or ("_secret" in arg) or ("_pem" in arg)): | ||
| value = '<span title = "{}"> (hidden)</span>'.format(value) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.