Fix case-insensitive semantics for LinkedCaseInsensitiveMap entrySet #36056
+43
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Align
LinkedCaseInsensitiveMap’sentrySet()view with the map’s case-insensitive key contract by makingentrySet().contains(..)andentrySet().remove(..)perform case-insensitive key resolution.Background
LinkedCaseInsensitiveMapprovides case-insensitive behavior forcontainsKey/get/remove. However,entrySet()operations previously delegated to the backing map’s entry set, which performs case-sensitive key comparisons. As a result, entry-based operations could miss existing mappings when callers used different key casing.Example
Changes
Tests
./gradlew :spring-core:test --tests org.springframework.util.LinkedCaseInsensitiveMapTests./gradlew :spring-core:test