fix(audits): fix report categories displayed in the wrong order#90
Open
LANGERGabrielle wants to merge 1 commit into
Open
fix(audits): fix report categories displayed in the wrong order#90LANGERGabrielle wants to merge 1 commit into
LANGERGabrielle wants to merge 1 commit into
Conversation
PG's jsonb type does not preserve the order of keys. The report generator relies on the "categories" property to be in a specific order.
LANGERGabrielle
commented
Aug 22, 2022
| @@ -0,0 +1 @@ | |||
| ALTER TABLE lighthouse_audits ALTER COLUMN report_json TYPE json | |||
Author
There was a problem hiding this comment.
PG's jsonb type does not preserve the order of keys.
The report generator relies on the "categories" property to be in a specific order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current behaviour :
With this patch :