fix(resolver): validate flag name format in resolve and apply#412
Open
nicklasl wants to merge 7 commits into
Open
fix(resolver): validate flag name format in resolve and apply#412nicklasl wants to merge 7 commits into
nicklasl wants to merge 7 commits into
Conversation
Reject flag names that don't match the expected `flags/{id}` format
where id is 2-63 lowercase alphanumeric/hyphen characters.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validate_flag_nameto the Rust core resolver, enforcing theflags/{id}format where{id}is 2-63 chars of[a-z0-9-]resolve_flags(requested flag names) andapply_flags(applied flag names)DEFAULT_ID_PATTERNinNameFactoryImplDiscussion point
Currently invalid flag names are silently dropped. An alternative would be to log a warning via the WASM host
log_messageimport, but that would require adding thewasm_msg_host_log_messagehost function to JS, Go, and Python providers (Java already has it). Is silent drop sufficient, or should we add observability here?Test plan
🤖 Generated with Claude Code