Update loginvalidator.class.php

[bertoost]

Change _getErrorMessage() protected into public, to make it available for third party validators (same as I did for FormIt ;-))

[jpdevries]

Thanks got this merged at modxcms/Login
modxcms@12e72c5

[jpdevries]

@bertoost i'm trying to decide if is a 'new feature' and bump the version from 1.8.1 to 1.9.0

[bertoost]

just an update I guess? just 1.8.2 then?
This is so little change, probably no one uses this unless me :D haha

[jpdevries]

Well, i'm trying to follow semver.org as close as possible. If it is a new feature, it would be a minor bump (1.9.0), but if it is a modification to an existing feature it could be a patch (1.8.1)

[bertoost]

I understand. I try to do such too. But do what feels right for you. Are there a couple of new features added? or just this one?

[jpdevries]

This is the changelog right now:

- [#56] Add Swedish translations
- [#57] Add Italian translations
- [#58] Add Russian translations
- [#60] Disable adding default query string parameter to the redirect on confirm registration
- [#62] Make error message available to third party validators

I'm trying to decide if error messages are a new feature or a modification to an existing one

[bertoost]

I should go for 1.8.1 or such. My change is just from a "protected" to "public" function. It's a little thing.

Ps. do you need any Dutch translation? Is there something missing I can help with?

[jpdevries]

Dutch translations would be great!

[bertoost]

There is already right? Updates needed?

[jpdevries]

I'm not sure, I don't speak Dutch :(

I wish i did! I mean my last name is DeVries...

[bertoost]

I don't have a fork (yet).. but you know maybe there are differences in keys in the lexicon files?

[jpdevries]

I'm not sure. But if you submit a new PR can you do it at the new modxcms/Login location?

—
Sent from Mailbox for iPhone

On Mon, Oct 21, 2013 at 2:15 AM, Bert Oost notifications@github.com
wrote:

I don't have a fork (yet).. but you know maybe there are differences in keys in the lexicon files?

Reply to this email directly or view it on GitHub:
#62 (comment)