Prevent config from changing during this test#1300
Merged
Conversation
If a parallel test changes the config to use legacy encoding then this test will fail when trying to write a layer with blob annotation. Signed-off-by: J Robert Ray <jrray@imageworks.com> Signed-off-by: J Robert Ray <jrray@jrray.org>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
rydrman
approved these changes
Dec 3, 2025
jrray
added a commit
that referenced
this pull request
Dec 15, 2025
Despite the efforts in #1224, #1284, and #1300, test_sync_ref_including_annotation_blob continues to spuriously fail because the current encoding format is set to legacy. This change actively tries to change to the flatbuffers encoding format for the duration of the test. Signed-off-by: J Robert Ray <jrray@jrray.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a parallel test changes the config to use legacy encoding then this test will fail when trying to write a layer with blob annotation.
Spun out of #1289 since we're still experiencing spurious CI failures.