Skip to content

Comments

outbound-http: Fix spin interface DNS resolution#3409

Merged
lann merged 1 commit intomainfrom
fix-outbound-http-spin-dns
Feb 23, 2026
Merged

outbound-http: Fix spin interface DNS resolution#3409
lann merged 1 commit intomainfrom
fix-outbound-http-spin-dns

Conversation

@lann
Copy link
Collaborator

@lann lann commented Feb 23, 2026

tokio::net::lookup_host confusingly requires a port number.

Signed-off-by: Lann Martin <lann.martin@fermyon.com>
@lann lann requested a review from karthik2804 February 23, 2026 18:35
Copy link
Contributor

@karthik2804 karthik2804 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the change and LGTM!

@lann lann enabled auto-merge February 23, 2026 18:51
Copy link
Collaborator

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's bonkers. Thanks for figuring it out.

@lann lann merged commit 60d1d1b into main Feb 23, 2026
17 checks passed
@lann lann deleted the fix-outbound-http-spin-dns branch February 23, 2026 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants