Skip to content

[AI] Expand Test Coverage - eldritch-core/dsl #1632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
google-labs-jules wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[AI] Expand Test Coverage - eldritch-core/dsl #1632

google-labs-jules wants to merge 1 commit into from

Conversation

@google-labs-jules
Copy link
Contributor

@google-labs-jules google-labs-jules bot commented Jan 23, 2026

This PR increases test coverage for eldritch-core by adding a new integration test file tests/error_suggestions_and_parity.rs. This file targets specific edge cases and error messages that were previously implicit or under-tested, specifically the fuzzy matching logic for method suggestions and strict parity behavior for string methods compared to Python.

Changes:

  • Created implants/lib/eldritchv2/eldritch-core/tests/error_suggestions_and_parity.rs.
  • Added tests for Levenshtein distance-based suggestions (e.g., apend -> append).
  • Added tests for str.replace argument count enforcement.
  • Added tests for str.index/str.rindex failure modes.
  • Added tests for str.count behavior.

PR created automatically by Jules for task 12647968531832133183 started by @KCarretto

@google-labs-jules
Expand Test Coverage - eldritch-core
2a9d004 
Added a new test file `implants/lib/eldritchv2/eldritch-core/tests/error_suggestions_and_parity.rs` to cover:
- "Did you mean?" error suggestions for invalid method calls on List, Dict, Set, and String types.
- Parity checks for `str` methods:
    - Argument count validation for `replace`.
    - Runtime error behavior for `index` and `rindex` (ValueError vs -1).
    - `count` method behavior on strings.
    - `join` method validation for non-list arguments.

Verified stability by running the new tests 20 times and ran full regression tests for `eldritch-core`.
@google-labs-jules
Copy link
Contributor Author

google-labs-jules bot commented Jan 23, 2026

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2026

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
3107    ±0 3107    ±0 0    ±0 0    ±0 0    ±0 0    ±0 1ms    ±0

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#595 ✅ 3107 3107 0 0 0 0 28.7s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
3107 0 0 11.6s

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
eldritch: sys::dll_inject_impl::tests::test_dll_inject_simple 1 11.6s 11.6s
eldritch: random::string_impl::tests::test_string_length 3 6.1s 8.7s
eldritch: random::string_impl::tests::test_string_length 3 6.1s 8.7s
eldritch: random::string_impl::tests::test_string_length 3 6.1s 8.7s
eldritch: runtime::tests::test_library_async 3 2.5s 6.8s
eldritch: runtime::tests::test_library_async 3 2.5s 6.8s
eldritch: runtime::tests::test_library_async 3 2.5s 6.8s
eldritch: runtime::tests::time_bindings 3 2.0s 6.0s
eldritch: runtime::tests::time_bindings 3 2.0s 6.0s
eldritch: runtime::tests::time_bindings 3 2.0s 6.0s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant