Skip to content

Conversation

@bact
Copy link
Collaborator

@bact bact commented Sep 28, 2025

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@bact bact added the documentation Improvements or additions to documentation label Sep 28, 2025
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @bact

@goneall goneall merged commit 9d127a9 into spdx:master Oct 5, 2025
1 check passed
@bact bact deleted the add-javadoc-workflow branch October 5, 2025 08:50
@bact
Copy link
Collaborator Author

bact commented Oct 6, 2025

Needs to enable this in GitHub Settings -> Pages

@goneall
Copy link
Member

goneall commented Oct 6, 2025

Needs to enable this in GitHub Settings -> Pages

I enabled the pages, but it is still not showing up.

There is nothing in the gh-pages branch and the action log showed success for the gh-pages deployment, but the artifact size is very small - so it looks like the JavaDocs has not been generated:

[build](https://github.com/spdx/tools-java/actions/runs/18288867655/job/52070890512#logs)
succeeded 14 minutes ago in 4s
Search logs
1s
1s
0s
Run actions/upload-pages-artifact@v3
Run echo ::group::Archive artifact
Archive artifact
Run actions/upload-artifact@v4
With the provided path, there will be 1 file uploaded
Artifact name is valid!
Root directory input is valid!
Beginning upload of artifact content to blob storage
Uploaded bytes 266
Finished uploading artifact content to blob storage!
SHA256 digest of uploaded artifact zip is a25e1639ac13f79cbb1a50dc43a75f3787cfcd12ac1974ca47081c8780ef2359
Finalizing artifact upload
Artifact github-pages.zip successfully finalized. Artifact ID 4195125912
Artifact github-pages has been successfully uploaded! Final size is 266 bytes. Artifact ID is 4195125912
Artifact download URL: https://github.com/spdx/tools-java/actions/runs/18288867655/artifacts/4195125912

@bact
Copy link
Collaborator Author

bact commented Oct 6, 2025

Thank you. Will take a look more at this.

@bact
Copy link
Collaborator Author

bact commented Oct 6, 2025

I saw you fixed it. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants