fix: add creator comment field in Spdx2to3converter#388
Open
aniruth37 wants to merge 1 commit intospdx:masterfrom
Open
fix: add creator comment field in Spdx2to3converter#388aniruth37 wants to merge 1 commit intospdx:masterfrom
aniruth37 wants to merge 1 commit intospdx:masterfrom
Conversation
Author
Author
|
@bact |
bact
approved these changes
Feb 6, 2026
Collaborator
bact
left a comment
bact
left a comment
There was a problem hiding this comment.
LGTM. The orElse(null) in setComment() pattern is similar to other instances in the codebase.
Thank you for the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #387