Open
Conversation
3 tasks
…is assumed. This ensures full backwards compatibility. Also now the loader no longer take the folder version argument.
It is still there but does not have any effect.
…g to the comment.
This is now explicitly done in the `generate_program_folder()` function.
Now there is more separation.
It now supports `probe` that allows to fail in a gracefull way.
philip-paul-mueller
changed the title
Collaborator
Author
|
A point of discussion is if the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The initial idea was to reduce the size of the cache folder, by only storing the components that are needed.
To this end the code generator was modified such that different versions of build folder could be generated.
Currently there are only two versions:
full: Which is the old full version, i.e. everything in a single folder.production: This is a reduced folder and only contains the libraries (stub and program library) as well the version.The implementation has two parts. First
generate_program_folder()was modified such that it only generates the parts that are absolutely needed, such as source files and anything else would not be generated in the first place.Then
compile_and_configure()was modified such that it would remove the parts that are no longer needed (an example would be the source files which are needed for compilation but not afterwards).The changes are backwards compatible. Thus, caches that were generated before this PR will still work, but they should be phased out.
In Addition:
sdfg.view()fails if there are external SDFGs (727cfb1)sdfg.generate_code()no longer generates the source maps as a side effect and writes them to disc. Instead they are generated by thegenerate_program_folder()(5e1694b).ReloadableDLL, that changed its interface.